authentik
authentik copied to clipboard
goauthentik
website/integrations: fix Frappe docs
Details
I have dogfooded my own docs and found out I screwed up and included a trailing slash where it should not have been.
Checklist
- [ ] Local tests pass (
ak test authentik/) - [ ] The code has been formatted (
make lint-fix)
If an API change has been made
- [ ] The API schema has been updated (
make gen-build)
If changes to the frontend have been made
- [ ] The code has been formatted (
make web)
If applicable
- [X] The documentation has been updated
- [X] The documentation has been formatted (
make website)
Deploy Preview for authentik-storybook canceled.
| Name | Link |
|---|---|
| Latest commit | c38eec8578fa9756ce7d750d2af72cb042a56247 |
| Latest deploy log | https://app.netlify.com/sites/authentik-storybook/deploys/66c1b9db8504570008b75d91 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for authentik-docs ready!
| Name | Link |
|---|---|
| Latest commit | c38eec8578fa9756ce7d750d2af72cb042a56247 |
| Latest deploy log | https://app.netlify.com/sites/authentik-docs/deploys/66c1b9dbe17533000836f224 |
| Deploy Preview | https://deploy-preview-10957--authentik-docs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
why did you include all the changes of your previous merge request instead of simply editing the redirect url
why did you include all the changes of your previous merge request instead of simply editing the redirect url
Fair question from @4d62 indeed. Seems odd to replace all of the graphics (only some show the trailing slash?), the entry in the sidebar.js file, and every bit of content, just to remove a trailing slash? But it looks like there are quite a few other commits (like the typo of "butoon"--sorry I missed that the first time!), so... I don't see any harm in merging this PR (basically replacing the whole page). If you are up for sharing your thoughts behind this that would be good, and of course met us know if you have any questions about a more typical process/workflow. Maybe I am missing something myself.
Oh. Actually now I see there are merge conflicts on the images... can you sort those and push again, please?
Hi @Infernogeek1 I'm closing this PR; if it turns out the trailing slash is indeed needed (or not needed) we can update the docs. We don't need the images though. Thanks, all!