goenv icon indicating copy to clipboard operation
goenv copied to clipboard

Homebrew installation instructions refer to caveats for goenv init that don't appear?

Open moogzy opened this issue 3 years ago • 2 comments

README installation instructions for homebrew states the following:

After installation, you'll need to add eval "$(goenv init -)" to your profile (as stated in the caveats displayed by Homebrew — to display them again, use brew info goenv). You only need to add that to your profile once.

The init doesn't happen automatically so I added the eval to my .zprofile and restarted the shell which triggered the setting of GOENV and manipulating PATH. Should the caveat still be appearing? I'm happy to send a PR to update the install documentation if the caveat isn't expect to appear anymore so that it's a default instruction for users.

This is the output of homebrew installation:

$ brew install goenv                                                                                                                                                                                                                                                                               
==> Downloading https://ghcr.io/v2/homebrew/core/goenv/manifests/1.23.3-1
######################################################################## 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/goenv/blobs/sha256:18e8cdaeba562696634782aff8f2affff1201d91fab4334346942b11ece548a5
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:18e8cdaeba562696634782aff8f2affff1201d91fab4334346942b11ece548a5?se=2021-11-08T09%3A00%3A00Z&sig=WWOhDiIDU13lMlVJLUiUzJXKqjWNNo3VCd3Ba4MbNbc%3D&sp=r&spr=https&sr=b&sv=2019-12-12
######################################################################## 100.0%
==> Pouring goenv--1.23.3.all.bottle.1.tar.gz
🍺  /usr/local/Cellar/goenv/1.23.3: 158 files, 265.2KB
Warning: Calling bottle :unneeded is deprecated! There is no replacement.
Please report this issue to the argoproj/tap tap (not Homebrew/brew or Homebrew/core):
  /usr/local/Homebrew/Library/Taps/argoproj/homebrew-tap/kubectl-argo-rollouts.rb:8

Output of brew info goenv:

$ brew info goenv                                                                                                                                                                                                                                                                                   
goenv: stable 1.23.3 (bottled), HEAD
Go version management
https://github.com/syndbg/goenv
/usr/local/Cellar/goenv/1.23.3 (158 files, 265.2KB) *
  Poured from bottle on 2021-11-08 at 16:54:26
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/goenv.rb
License: MIT
==> Options
--HEAD
	Install HEAD version
==> Analytics
install: 972 (30 days), 2,872 (90 days), 9,543 (365 days)
install-on-request: 967 (30 days), 2,866 (90 days), 9,535 (365 days)
build-error: 0 (30 days)

moogzy avatar Nov 08 '21 09:11 moogzy

@syndbg can you provide an update on this please?

moogzy avatar Jul 21 '22 09:07 moogzy

I have to check. I'm not an owner of the homebrew formula.

syndbg avatar Jul 21 '22 09:07 syndbg

Came here to report the same.

hmijail avatar Dec 22 '22 02:12 hmijail

Closing this as there is no movement for a year now

ChronosMasterOfAllTime avatar Aug 24 '23 18:08 ChronosMasterOfAllTime