jet icon indicating copy to clipboard operation
jet copied to clipboard

feat: add preliminary json support for qrm_pgx.

Open DevX86 opened this issue 6 months ago • 4 comments
trafficstars

DevX86 avatar Apr 28 '25 01:04 DevX86

@go-jet Something like this?

DevX86 avatar Apr 28 '25 01:04 DevX86

Self reminder on the stmt.QueryPGX() to avoid the

query, args := stmt.Sql()
_, err := qrm.QueryPGX(ctx, r.db, query, args, row)
if err != nil {
	return err
}
	
return nil

We want to make a statement.go type pgx implementation but also wanted to avoid PGX spam on the stmt. intellisense. Two ideas were put forth, stmt.PGX.Query() and pgx.Query() personally, leading towards the latter, less dots and it gives things a more modular development experience.

DevX86 avatar Apr 29 '25 01:04 DevX86

@go-jet Something like this?

Yeah, looks good.

go-jet avatar Apr 30 '25 17:04 go-jet

Codecov Report

:x: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 90.39%. Comparing base (0a336d6) to head (837bd92). :warning: Report is 3 commits behind head on pgx.

Files with missing lines Patch % Lines
qrm/qrm_pgx.go 0.00% 51 Missing :warning:

:x: Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##              pgx     #495      +/-   ##
==========================================
- Coverage   90.94%   90.39%   -0.55%     
==========================================
  Files         137      137              
  Lines        8422     8473      +51     
==========================================
  Hits         7659     7659              
- Misses        574      625      +51     
  Partials      189      189              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 04 '25 08:05 codecov[bot]