jet
jet copied to clipboard
go-jet
Should not have to wrap all WHERE values.
Is your feature request related to a problem? Please describe.
It should not be necessary to wrap values that are being used for comparisons.
Here is what the code currently looks like, where we are wrapping id in Uint64():
id := 16
query := SELECT(
Accounts.AllColumns
).FROM(
Accounts,
).WHERE(
Accounts.ID.EQ(Uint64(id)),
)
Describe the solution you'd like Passing in regular values should be supported:
id := 16
query := SELECT(
Accounts.AllColumns
).FROM(
Accounts,
).WHERE(
Accounts.ID.EQ(id),
)
Passing in a slice directly should be supported:
names := []string{"bob", "jane", "john"}
query := SELECT(
Accounts.AllColumns,
).FROM(
Accounts,
).WHERE(
Accounts.Name.IN(names),
)
EQ operator should be able to accept any expression not just a parameter. For instance:
Accounts.ID.EQ(Book.ID.ADD(Int(3))
Since golang doesn't allow method name overloading this is the only way.
Alternatively, we can add a new method for each type, but that would be just a marginally improvements:
Accounts.ID.EQ(Uint64(id)),
// vs
Accounts.ID.EQUint64(id),
Note just ( and ) disappears from the code. Not worth of adding 100 of new methods into library source code just to eliminate two brackets.
Why not have EQ accept any and then wrap the parameter in whatever function is appropriate for the value's type/interface?
Could it accept a generics-constraint/interface that includes both the correct Expression type, and also the base primitives?
The last time I tried with generics, the issue was that it was not possible to have generic method on a type. The whole type has to be generic. Maybe that has changed in the meantime. Or maybe there is some other workaround. It is possible to redefine some base type and then make it implement all Expression methods. But still when you get base type from http request you will have to cast it into new type. Which will look basically the same as what we currently have.
The last time I tried with generics, the issue was that it was not possible to have generic method on a type. The whole type has to be generic. Maybe that has changed in the meantime.
It has not changed, and as far as I've read it is unlikely to change in the future too. Some technical constraints, IIRC.
FWIW I like the current interface, it makes it very explicit when you're passing in something that will be compiled into a SQL parameter vs when you're passing some other type of expression.
