gitea icon indicating copy to clipboard operation
gitea copied to clipboard

The PRs link in release page will get network error

Open yp05327 opened this issue 1 year ago • 5 comments
trafficstars

Description

IMG_2701 https://gitea.com/gitea/act_runner/releases

I will check it later. Not sure whether this is a bug now.

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

gitea.com

Database

None

yp05327 avatar May 29 '24 13:05 yp05327

Does not reproduce for me:

image

silverwind avatar May 29 '24 13:05 silverwind

I did this on mobile. On mobile, there's no way to display this tooltips unless you click it. But if you click it, it will go to the PR's page. And when you back to this page, you will see network error. So I did two things together: show the tooltips (a bit faster) and go to the PR's page. So for mobile view, maybe we need to allow user click a URL to show the tooltip at the first time if it has a tooltip, then the second time the click will go to the target link.

yp05327 avatar May 29 '24 23:05 yp05327

I can follow. When you click a link, it starts loading, but aborts because the page unloads. When you hit the back button, you get a cached page from bfcache which apparently also caches the error popup.

As for solutions, I think we could try to cancel the request before page unload and not show a error in such a case.

silverwind avatar May 30 '24 00:05 silverwind

When you click a link, it starts loading, but aborts because the page unloads.

Yes, that's it. 👍

yp05327 avatar May 30 '24 00:05 yp05327

https://github.com/go-gitea/gitea/pull/31181 will fix this and other problems with that popup.

silverwind avatar May 30 '24 15:05 silverwind