gitea icon indicating copy to clipboard operation
gitea copied to clipboard

Published 20 hours ago • verified publisher icon go-gitea

Fix issue comment number

Open lunny opened this issue 1 year ago • 4 comments

Fix #22419

lunny avatar Apr 18 '24 07:04 lunny

How much work would it be to add a migration that fixes the counts on existing issues? Would probably be a long-running migration on big instances, right?

Also, not sure if such a migration would be backportable at all as it would likely skip migration numbers (a design flaw in the migration system).

silverwind avatar Apr 19 '24 07:04 silverwind

How much work would it be to add a migration that fixes the counts on existing issues? Would probably be a long-running migration on big instances, right?

Yes, so I don't think the migration is necessary. The number will be corrected when next comment created/updated.

Also, not sure if such a migration would be backportable at all as it would likely skip migration numbers (a design flaw in the migration system).

lunny avatar Apr 19 '24 09:04 lunny

Yeah it's not really a requirement from me, more like a "nice to have" but likely too complicated with the migration backport to really be justified.

silverwind avatar Apr 19 '24 09:04 silverwind

Willing to approve this without migration once you fix the tests :)

silverwind avatar Apr 23 '24 20:04 silverwind

CI failure is related

wxiaoguang avatar Dec 30 '24 09:12 wxiaoguang