gitea icon indicating copy to clipboard operation
gitea copied to clipboard

Published 20 hours ago • verified publisher icon go-gitea

Improve and fix bugs in runner management page

Open yp05327 opened this issue 2 years ago • 9 comments

Changes:

  • Add no permission to edit tooltip image
  • fix the logic in ActionRunner.Editable
    • Gitea admin user can edit runner in org/repo runner settings page image
    • Org owner can edit org/repo runner in org's repo runner settings page image
    • org admin can only edit org's repo runner image
  • add missed locale word: runners.task_list.no_tasks
  • ~~fix overflow of Recent tasks on this runner~~ This has been fixed. Before: image After: image

yp05327 avatar Apr 27 '23 02:04 yp05327

image

Edit icon looks slighly misaligned with cross icon horizontally.

silverwind avatar Apr 29 '23 13:04 silverwind

image

Edit icon looks slighly misaligned with cross icon horizontally.

Done.

yp05327 avatar May 01 '23 01:05 yp05327

@yp05327 Is this PR still relevant? If so, could you update it?

denyskon avatar Jan 21 '24 15:01 denyskon

I'll try to update it.

yp05327 avatar Jan 22 '24 00:01 yp05327

Added individual runner support.

yp05327 avatar Jan 22 '24 02:01 yp05327

Update is done.

yp05327 avatar Jan 22 '24 08:01 yp05327

After this, it will be possible to edit a global/org runner on the settings page of a repo if the doer has permission. It doesn't look really good to me.

image image

Just my opinion, I would say it could be better to redirect to org/admin settings page.

It seems this hasn't been followed?

lunny avatar Jan 22 '24 13:01 lunny

This has been supported in https://github.com/go-gitea/gitea/pull/24366/commits/110b928d97b61becf1fc91805d12f1819441bd9e

But I noticed a problem. If admin want to edit a individual runner from admin panel which doesn't belong to him, which URL should we use? /user/settings/actions/runners/{id} seems strange as this runner doesn't belong to him. But if we use /admin/actions/runners/{id}, then we have several entry points to this runner ( but for the admin user, there's only one )

yp05327 avatar Jan 23 '24 00:01 yp05327

Isn't the second option used currently? Looks correct to me, the admin should always use admin routes if possible

denyskon avatar Jan 24 '24 07:01 denyskon