gitea icon indicating copy to clipboard operation
gitea copied to clipboard

Make the vscode clone link respect transport protocol (#20557)

Open monim67-renforce opened this issue 3 years ago • 3 comments

Backports #20557

monim67-renforce avatar Sep 09 '22 18:09 monim67-renforce

Is it ready to be merged now?

monim67 avatar Sep 13 '22 15:09 monim67

Is it ready to be merged now?

Usually we only backport bugfixes, not enhancements. Also the CI complains and wants the change above.

noerw avatar Sep 13 '22 16:09 noerw

For me it's a bug, because I have HTTPS git disabled but clone in VSCode button always gives me HTTPS link. It never changes to SSH link. I had to override the template to replace HTTPS with SSH link to get it to work. I have to do this everytime a new version is released 😞

monim67 avatar Sep 14 '22 03:09 monim67

@monim67-renforce : "This branch is out-of-date with the base branch": please enable Allow Edits from Maintainers, or update with 1.17 branch.

wxiaoguang avatar Sep 20 '22 08:09 wxiaoguang

@wxiaoguang I cannot give write access as I created the PR from wrong account. None of the account has that allow edit checkbox now. I have updated the branch by merge.

monim67 avatar Sep 20 '22 10:09 monim67

I see. Just now there is a new commit in 1.17, could you update it again? Then we can get this merged in next time.

wxiaoguang avatar Sep 20 '22 10:09 wxiaoguang

@wxiaoguang updated again.

monim67 avatar Sep 20 '22 10:09 monim67

Another bug: Golang doesn't like the string syntax: `...//...`, it will truncate the // as comment, then result in bad script code.

wxiaoguang avatar Sep 22 '22 01:09 wxiaoguang

https://github.com/go-gitea/gitea/issues/21224#issuecomment-1254356110

wxiaoguang avatar Sep 22 '22 01:09 wxiaoguang