gitea
gitea copied to clipboard
go-gitea
Add user/organization code search
It might be a good Idea to also add search for Issue/PRs and other things.
Absolute URL like HTMLURL should not be used.
- https://github.com/go-gitea/gitea/issues/19345
@wxiaoguang what would be the alternative?
Always use relative links(like "/AppSubUrl/org/repo/....") on Web UI
Oh, and another thing I've noticed (doesn't need to be fixed in this PR): Why exactly do we make another request when selecting a type? Couldn't we also do that in the frontend?
@delvh these changes should be done in other PR as otherwise look and naming will be inconsistent with global and repository code search pages!
There are already too many refactorings that now touches code outside of scope of this PR
Could we avoid squash or rebase + force push when review starts?
It's not clear what has changed since last review, the review should start from beginning again .........
@delvh these changes should be done in other PR as otherwise look and naming will be inconsistent with global and repository code search pages!
I accept not renaming Match to Exact.
But everything else is absolutely needed.
I strongly disagree that displaying the tooltips is out of scope.
Or do you mean because the tooltips aren't present in the other search, they shouldn't be added???
In that case I disagree even more. Simply because this wassn't done well previously doesn't mean we need to do it badly now.
Added tooltips and refactored code in all code search places to be consistent
