delve icon indicating copy to clipboard operation
delve copied to clipboard

DAP Evaluate and SetVariables response not containing `type` with `supportsVariableType`.

Open gfszr opened this issue 3 years ago • 3 comments
trafficstars

When issuing a SetVariable request or an Evaluate request, the response contains the type of the new value if supportsVariableType is negotiated upon DAP initialization. However, it is currently not returned:

https://github.com/go-delve/delve/blob/6440b3ba9216cb936f43318b96df540cf56b216f/service/dap/server.go#L2642-L2644

From a client's perspective the type is very important as SetVariables responses might return a different type than the original variable, let alone Evaluate which can return an arbitrary type.

Dlv Version: 1.9.1 Go Version: 1.16 Expected Result: EvaluateResponse/SetVariablesResponse contains the type of the variable. Actual Result: Type is not returned at all.

gfszr avatar Oct 21 '22 12:10 gfszr

Closing since a fix was merged.

aarzilli avatar Nov 21 '22 08:11 aarzilli

@aarzilli was a fix merged for the missing type in SetVariableResponse as well?

gfszr avatar Nov 24 '22 08:11 gfszr

No.

aarzilli avatar Nov 24 '22 08:11 aarzilli