add a button to mark probable false positives

[llogiq]

The idea is that we can get better feedback on false positives while making it simple to report.

For the UI, I'd suggest a single button that pops up a dialog with a bit of explanation, a textbox for further information and a submit button.

[mcarton]

:+1:

[gnunicorn]

Thanks for the suggestion @llogiq. Could you elaborate a little bit: what false positives? A success which is none or clippy reporting things, which you consider not problematic?

The first I'd consider a bug and the issue tracker should be used. The second is a clippy configuration thing and we are currently investigating how to support that. Or is it something else?

[llogiq]

We deem false positives all instances of clippy reporting a problem where either there is none (and by this I mean objectively that the thing the lint should warn against isn't there, not opinionated lints) or the contained information isn't readily actionable upon, because the compiler actually forbids implementing the suggestion (where applicable).

The resulting report would be of interest to clippy devs because we'd have a larger number of examples to test on and people will sometimes not bother to write an issue (or not followup if there already is one, etc.)

[gnunicorn]

Interesting suggestion. I'll put this into the status-page milestone, adding a button to allow reporting of false positives.

@llogiq would a button that opens and pre-fills a github issue on rust-clippy be sufficient? It could also append the log and a link to the repo. Because I am currently not sure how to handle it otherwise.

[llogiq]

I don't like the idea of spamming our issues. At best there would be 1 issue called reported false positives and you could edit it to add links.

Or it could be a gist with markdown or something. The idea is that it should be easy to parse and update. Perhaps old false positives that are superceded by new commits could even be removed?

[mcarton]

https://github.com/Manishearth/rust-clippy/issues/746 gave me a similar idea: it would be nice if internal compiler errors could be reported automatically.