laravel-shopify icon indicating copy to clipboard operation
laravel-shopify copied to clipboard

Adding support for Laravel 9

Open steveperrycreative opened this issue 3 years ago • 25 comments

steveperrycreative avatar Mar 03 '22 17:03 steveperrycreative

Thanks @steveperrycreative , can you also add the associated version in the CI strategy ?

lucasmichot avatar Mar 09 '22 15:03 lucasmichot

Yes @lucasmichot I'll take a look when I get chance.

Thanks.

steveperrycreative avatar Mar 10 '22 14:03 steveperrycreative

I have added them @steveperrycreative

lucasmichot avatar Mar 13 '22 16:03 lucasmichot

Closes #1090

lucasmichot avatar Mar 13 '22 16:03 lucasmichot

@osiset can you please help us with a review?

adrianmihaila avatar Mar 16 '22 13:03 adrianmihaila

@osiset can you please merge and approved it?

litalboa avatar Mar 29 '22 06:03 litalboa

@osiset Please review it.

kamalpal avatar Apr 17 '22 02:04 kamalpal

I tested this branch and when trying to publish the config I get:

 php artisan vendor:publish --tag=shopify-config
No publishable resources for tag [shopify-config].

I'm using composer repositories to ensure I get your branch with Laravel 9 fixies in place.

Is this expected or I am missing something, going to dive into this part shortly to see if it was me.

jamescowie avatar Apr 18 '22 13:04 jamescowie

@osiset Hello, I'm trying install osiset package on laravel 9 but I'm having errors. Have you added the support for laravel 9 image

rizwanWixpa098 avatar Jun 03 '22 07:06 rizwanWixpa098

osiset still not install on laravel 9 and give error below

### Your requirements could not be resolved to an installable set of packages. Problem 1 - Root composer.json requires osiset/laravel-shopify ^17.1 -> satisfiable by osiset/laravel-shopify[v17.1.0, v17.1.1, 17.1.x-dev]. - osiset/laravel-shopify[v17.1.0, ..., 17.1.x-dev] require laravel/framework ^7.0 || ^8.0 -> found laravel/framework[v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev] but it conflicts with your root composer.json require (^9.11).

abubakar0101 avatar Jun 03 '22 07:06 abubakar0101

I tried to install v17 of osiset but got these errors as well image

rizwanWixpa098 avatar Jun 03 '22 07:06 rizwanWixpa098

@osiset I am facing a problem to installing ossiset package version 17 and 16 in laravel 9

image

zulunran avatar Jun 03 '22 07:06 zulunran

@rizwanWixpa098 @abubakar0101 @zulunran

Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

lucasmichot avatar Jun 03 '22 07:06 lucasmichot

@rizwanWixpa098 @abubakar0101 @zulunran

Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

Yes this package does not yet support Laravel 9.x and not install on laravel 9

abubakar0101 avatar Jun 03 '22 07:06 abubakar0101

@rizwanWixpa098 @abubakar0101 @zulunran

Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

this package is not supported yet for larave9

zulunran avatar Jun 03 '22 07:06 zulunran

Yes, as of this PR implementing Laravel 9.x support is obviously still open.

When Tyler will have reviewed it, it will be merged and a new release will be created. Meanwhile you can also probably use your own fork of this repository.

lucasmichot avatar Jun 03 '22 07:06 lucasmichot

thanks for responding how long it will take to reviewed by @Tyler

zulunran avatar Jun 03 '22 08:06 zulunran

@rizwanWixpa098 @abubakar0101 @zulunran

Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

I'm having problem with installation of package in laravel 9 so I wanted to know either the package support laravel 9 or not??

rizwanWixpa098 avatar Jun 03 '22 08:06 rizwanWixpa098

thanks for responding how long it will take to reviewed by @tyler

Tyler, not @tyler

I don't know when, we all have day jobs and family chores

lucasmichot avatar Jun 03 '22 08:06 lucasmichot

@rizwanWixpa098 @abubakar0101 @zulunran Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

I'm having problem with installation of package in laravel 9 so I wanted to know either the package support laravel 9 or not??

If this PR is not merged, then it does not support Laravel 9.x

lucasmichot avatar Jun 03 '22 08:06 lucasmichot

@rizwanWixpa098 @abubakar0101 @zulunran Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

I'm having problem with installation of package in laravel 9 so I wanted to know either the package support laravel 9 or not??

If this PR is not merged, then it does not support Laravel 9.x

Okay Thanks for your response

rizwanWixpa098 avatar Jun 03 '22 09:06 rizwanWixpa098

Hello, any update for review and approval it. How can we use the test package thank you

smartdatasoft avatar Jun 21 '22 10:06 smartdatasoft

Hi, is there any news about this? May I help somehow? Would love to use it with my next app! :) Thanks for all your work on this package, it's a real game-changer for me.

francescomalatesta avatar Jun 28 '22 06:06 francescomalatesta

5 months later and there is still no support for Laravel 9 🙄

npabisz avatar Jul 29 '22 14:07 npabisz

5 years later and there is still no support from Shopify 🙄

lucasmichot avatar Jul 29 '22 15:07 lucasmichot

Thanks for the work everyone. Looking forward to building new projects when this gets merged.

araschy avatar Aug 16 '22 19:08 araschy

This is an amazing accomplishment. Great community <3 . I can almost taste this PR getting merged, were so close!

joeelia avatar Aug 17 '22 18:08 joeelia

The PR looks ok, @osiset you can merge?

itrack avatar Aug 21 '22 20:08 itrack

Is there any updates?

nahid avatar Aug 24 '22 12:08 nahid

I saw that this was going to be merged with #1191. Is there anything else that needs to be done before we can release it? Happy to help in any way.

ncpope avatar Aug 25 '22 10:08 ncpope