rubymotion-react icon indicating copy to clipboard operation
rubymotion-react copied to clipboard

CMD+R working in 0.11.0?

Open stevebooks opened this issue 10 years ago • 3 comments

Thanks so much for this sample app. I created another one to test around with here: https://github.com/stevebooks/ReactInMotion (I also borrowed some of your Readme)

I was able to update the version to 0.11.0, but the refresh doesn't work in the simulator. Anything special you did to get refresh working?

stevebooks avatar Sep 30 '15 23:09 stevebooks

I just tested and CMD+R doesn't work for me either : ( I've been using React Native without Rubymotion since I published this repo so I haven't noticed this...

gnestor avatar Oct 21 '15 19:10 gnestor

I've tested with the current version of ReactNative for a similar problem: dev menu won't show up when shake gesture sent to the simulator.

It seems the reason is that DevSupport is not enabled when RCT_DEV is not defined. (RubyMotion didn't pass this macro with a development build.

https://github.com/facebook/react-native/blob/6042de43c7e263010ba8d476f8f37663c826e85e/React/DevSupport/RCTDevMenu.m#L18

add #define RCT_DEV 1 to this file should enable live https://github.com/gnestor/rubymotion-react/blob/master/vendor/Pods/React/React/Base/RCTDefines.h#L39


2020-03 For newer version of ReactNative

vi node_modules/react-native/React/Base/RCTDefines.h

Change lines about RCT_DEV

#ifndef RCT_DEV
//#if DEBUG
#define RCT_DEV 1
//#else
//#define RCT_DEV 0
//#endif
#endif

Lax avatar Jun 22 '19 07:06 Lax

@Lax I just added you as a collaborator on this repo. I haven't used RubyMotion for 4+ years and I don't think I even have a license anymore. Feel free to submit a PR. Will review but you will also have merge rights.

gnestor avatar Jun 22 '19 16:06 gnestor