remark icon indicating copy to clipboard operation
remark copied to clipboard

Feature - load multiple sources

Open valvin1 opened this issue 6 years ago • 4 comments

As mentionend in #560 this feature allowes to load several sources using option sourceUrls instead of sourceUrl

      var slideshow = remark.create({
                                     sourceUrls: ['content/content1.md','content/content2.md']
                      });

valvin1 avatar Jun 09 '19 05:06 valvin1

Hi @valvin1! Thanks for creating this PR. I'd love to merge this, could you make the following changes:

  • there's an existing loadFromUrl function in the slideshow.js and you have added a loadFromUrls function - could you refactor your function, so it can be used in the scenario when options.sourceUrl is provided. That way, we only have one function that can load from the URL, regardless if there's one or multiple of them

  • add/update the tests in slideshow_test.js to test the scenarios when multiple URLs are provided

peterj avatar Jan 03 '20 20:01 peterj

@valvin1 any progress here? this feature is really cool and would like to see it :)

Jurigag avatar Feb 07 '20 13:02 Jurigag

Hi @peterj @Jurigag Peter thanks for your review unfortunately more than 6 monthes later I've forgotten this work. I'd love finishing it but not sure I'll have time to do it in the monthes to come. So if another one want to implement this feature he'll be welcome.

valvin1 avatar Feb 07 '20 13:02 valvin1

Hello @peterj

I decided to try and help take @valvin1's great idea across the finish line here. I have the work in my fork here.

Would it work best to just create a new PR from there? Or should I try and pull it into his original PR branch?

Thanks

kbens avatar Sep 16 '20 03:09 kbens