remark
remark copied to clipboard
Feature - load multiple sources
As mentionend in #560 this feature allowes to load several sources using option sourceUrls instead of sourceUrl
var slideshow = remark.create({
sourceUrls: ['content/content1.md','content/content2.md']
});
Hi @valvin1! Thanks for creating this PR. I'd love to merge this, could you make the following changes:
-
there's an existing
loadFromUrlfunction in theslideshow.jsand you have added aloadFromUrlsfunction - could you refactor your function, so it can be used in the scenario whenoptions.sourceUrlis provided. That way, we only have one function that can load from the URL, regardless if there's one or multiple of them -
add/update the tests in
slideshow_test.jsto test the scenarios when multiple URLs are provided
@valvin1 any progress here? this feature is really cool and would like to see it :)
Hi @peterj @Jurigag Peter thanks for your review unfortunately more than 6 monthes later I've forgotten this work. I'd love finishing it but not sure I'll have time to do it in the monthes to come. So if another one want to implement this feature he'll be welcome.
Hello @peterj
I decided to try and help take @valvin1's great idea across the finish line here. I have the work in my fork here.
Would it work best to just create a new PR from there? Or should I try and pull it into his original PR branch?
Thanks