glimmer-vm icon indicating copy to clipboard operation
glimmer-vm copied to clipboard

AttributeManager.setAttribute is megamorphic

Open chadhietala opened this issue 9 years ago • 3 comments

chadhietala avatar Oct 26 '16 01:10 chadhietala

@chadhietala do you mean this one https://github.com/tildeio/glimmer/blob/8409f1e8b6eae6ca323aea45ad0d69ab9d05e586/packages/glimmer-runtime/lib/dom/attribute-managers.ts#L72 ? Im not sure how to make it not megamorphic, as it will interact with a large number of different input types.

What did you have in mind?

stefanpenner avatar Oct 26 '16 01:10 stefanpenner

I agree. @krisselden mentioned this to me the other day on slack. I more or less created this issue because when Kris pings me with things I tend to believe they should be investigated 😄 .

chadhietala avatar Oct 26 '16 04:10 chadhietala

Is this still relevant?

locks avatar Apr 18 '20 15:04 locks