glimmer-vm icon indicating copy to clipboard operation
glimmer-vm copied to clipboard

support modifier delegate manager in debug render tree

Open patricklx opened this issue 1 year ago • 3 comments
trafficstars

im currently trying out ember beta which has the included modifier support for inspector, but i'm not getting an instance for e.g. did-insert modifier. think CustomModifierManager.getDebugInstance should return the delegate

patricklx avatar Apr 30 '24 08:04 patricklx

@chancancode @NullVoxPopuli

patricklx avatar Jun 12 '24 07:06 patricklx

From @chancancode :

[rather than || delegate] we need to add a hook that custom modifier managers can implement

NullVoxPopuli avatar Jun 12 '24 15:06 NullVoxPopuli

Would the hook need to be defined e.g. here: https://github.com/ember-modifier/ember-modifier/blob/ca6e654dd822f33e0ac82598ec33f61d835ccce1/ember-modifier/src/-private/class-based/modifier-manager.ts#L56 ?

Wouldn't that mean that everyone would need to update their implementation? Or update their dependency on ember/modifier?

patricklx avatar Jun 13 '24 11:06 patricklx