glimmer-vm icon indicating copy to clipboard operation
glimmer-vm copied to clipboard

Update list of allowed elements

Open NullVoxPopuli opened this issue 1 year ago • 1 comments

Potentials lists we could use:

  • https://www.npmjs.com/package/html-spec-tags?activeTab=readme

What we need:

  • SVG Elements
  • HTML Elements
  • etc?

NullVoxPopuli avatar Feb 29 '24 21:02 NullVoxPopuli

(or remove getTemplateLocals https://github.com/glimmerjs/glimmer-vm/issues/1550#issuecomment-1972012330 )

NullVoxPopuli avatar Feb 29 '24 21:02 NullVoxPopuli

@NullVoxPopuli is this still needed?

acorncom avatar Oct 17 '24 03:10 acorncom

Ya

NullVoxPopuli avatar Oct 17 '24 11:10 NullVoxPopuli

babel template compilation plugin is not using getTemplateLocals anymore. so, maybe not needed? and just remove the whole list? basically, now, everything is a html element, except if it has a js local. How does it work for non-strict mode?

https://github.com/emberjs/babel-plugin-ember-template-compilation/pull/33

patricklx avatar Oct 17 '24 11:10 patricklx

Ah! You're right! That fixes this repro from the linearGradient issue report https://github.com/glimmerjs/glimmer-vm/issues/1550

NullVoxPopuli avatar Oct 17 '24 11:10 NullVoxPopuli

We do still need to fix math elements tho:

#1593

NullVoxPopuli avatar Oct 17 '24 11:10 NullVoxPopuli