i18n-tasks icon indicating copy to clipboard operation
i18n-tasks copied to clipboard

JRuby support?

Open megatux opened this issue 2 years ago • 7 comments

The gem fails to install on JRuby, when installing better_html gem dependency (native c extension).

Env:

ruby -v
jruby 9.4.2.0 (3.1.0) 2023-03-08 90d2913fda OpenJDK 64-Bit Server VM 21+35-2513 on 21+35-2513 +jit [arm64-darwin]

megatux avatar Oct 23 '23 19:10 megatux

Could this gem be a dependency for MRI and not for JRuby (and TruffleRuby maybe)

megatux avatar Oct 24 '23 14:10 megatux

Yes, we need to handle which matcher to use for ERB. But we could probably make it optional. Feel free to give it a try 🙂

davidwessman avatar Oct 24 '23 16:10 davidwessman

It's entirely static analysis, so you can also just run it using MRI, even if your app uses JRuby.

glebm avatar Oct 24 '23 19:10 glebm

@megatux on main there is a version without better_html now. Can you see if that works on jruby for you?

davidwessman avatar Jan 16 '24 21:01 davidwessman

Seems to work fine. Thanks @davidwessman. Using the git URL in bundle file. When will be available in Rubygems?

megatux avatar Jan 17 '24 15:01 megatux

I'll push a release after a week or two have passed, to let potential bugs get discovered.

glebm avatar Jan 18 '24 00:01 glebm

Hi! was released yet?

megatux avatar Mar 20 '24 13:03 megatux

v1.0.14 is now out! Release was somewhat delayed due to another unrelated bug.

glebm avatar May 10 '24 02:05 glebm

We may want to consider adding jruby to the test suite to prevent regressions.

glebm avatar May 10 '24 02:05 glebm

JRuby added to the test suite in https://github.com/glebm/i18n-tasks/commit/2a9a9e0d4803b30b7c1353d4d63357aaa251302d

glebm avatar May 10 '24 05:05 glebm