wisp icon indicating copy to clipboard operation
wisp copied to clipboard

Update `gleam_json` dependency constraint

Open giacomocavalieri opened this issue 1 year ago • 8 comments
trafficstars

giacomocavalieri avatar Jul 01 '24 11:07 giacomocavalieri

What's the motivation here? I thought we were deliberately holding back on this one?

lpil avatar Jul 05 '24 20:07 lpil

Oops sorry I had no idea it was being intentionally held back. My problem is I ran into dependency resolution errors trying to add lustre_dev_tools as a dependency:

> gleam new wibble
> cd wibble
> gleam add lustre
> gleam add lustre_dev_tools --dev

error: Dependency resolution failed

An error occurred while determining what dependency packages and
versions should be downloaded.
The error from the version resolver library was:

Unable to find compatible versions for the version constraints in your
gleam.toml. The conflicting packages are:

- wibble
- lustre_dev_tools
- wisp
- gleam_json

The error message is not super useful but I thought the problem might be with wisp being too restrictive with the constraint.

giacomocavalieri avatar Jul 05 '24 20:07 giacomocavalieri

Brew is stuck on 26 for some reason so if we upgrade everything to the new gleam_json most macOS users won't be able to use them. This is why Lustre docs are saying to use the old version of gleam_json currently. Looks like you've installed the new one there.

lpil avatar Jul 08 '24 13:07 lpil

I guess this can be fixed/merged, Erlang OTP on homebrew mac is now on 27. I guess that's the blocker, according to this comment

pmbanugo avatar Sep 24 '24 14:09 pmbanugo

Why would someone prefer to use brew over something like asdf? I mean, can't just asdf be recommended over brew?

Papipo avatar Sep 25 '24 08:09 Papipo

Even if we recommended asdf it wouldn't change the fact that loads of macOS users will be using brew and breaking a really common library for them would be quite bad.

Personally I use brew and like how simple it is :)

giacomocavalieri avatar Sep 25 '24 09:09 giacomocavalieri

Would you mind rebasing on main please 🙏

lpil avatar Sep 30 '24 21:09 lpil

Done!

giacomocavalieri avatar Oct 02 '24 11:10 giacomocavalieri

Sorry Jak, I merged another PR that had this change also

lpil avatar Oct 11 '24 15:10 lpil

No worries!

giacomocavalieri avatar Oct 11 '24 16:10 giacomocavalieri