hexpm-rust icon indicating copy to clipboard operation
hexpm-rust copied to clipboard

Published 20 hours ago • verified publisher icon gleam-lang

Clippy lints

Open Pi-Cla opened this issue 1 year ago • 3 comments

Just clippy lints

Pi-Cla avatar May 31 '24 21:05 Pi-Cla

@lpil Should I add clap as a dependency and derive clap::ValueEnum so that OwnerLevel can be parsed by Clap? It seems like a similar approach is taken in say compiler-core but there a bunch of strum and serde macros are used instead.

Alternatively I could instead just make the clap command take a string and then manually pattern match against the string. This I think(?) would require a new Error variant to be added to gleam-core which mimics what Clap already says with invalid arguments though.

Pi-Cla avatar May 31 '24 22:05 Pi-Cla

I'm not sure what you mean, sorry. We don't want to depend on Clap at all here.

lpil avatar Jun 12 '24 13:06 lpil

This PR is probably obsolete by the changes that have been introduced in PR https://github.com/gleam-lang/hexpm-rust/pull/37 and PR https://github.com/gleam-lang/hexpm-rust/pull/38.

diemogebhardt avatar Feb 10 '25 13:02 diemogebhardt