php-parser icon indicating copy to clipboard operation
php-parser copied to clipboard

Published 20 hours ago • verified publisher icon glayzzle

fix: invalid parsing of traitalias

Open alexander-akait opened this issue 6 years ago • 3 comments

  • Refactor code using read_* for better maintenance
  • Fix parsing:
class MyClass1 {
    use HelloWorld { sayHello as abstract private test; }
}

It is invalid and should not be parsable.

  • Tests

alexander-akait avatar Sep 11 '19 14:09 alexander-akait

Coverage Status

Coverage decreased (-0.06%) to 95.806% when pulling 8741d13612b371a7a7b903c0e3ff2315876a85d7 on fix-and-refactor-trait-parsing into 0df5a4973ed22b21aa2c38a27f6a7cb258316af9 on master.

coveralls avatar Sep 11 '19 14:09 coveralls

Hi @evilebottnawi, not sure what to do with this PR, can we review it on 3.1 or does it introduce breaking changes ?

ichiriac avatar Jan 06 '20 19:01 ichiriac

Yes, let's do it in 3.1

alexander-akait avatar Jan 06 '20 19:01 alexander-akait