postiz-app icon indicating copy to clipboard operation
postiz-app copied to clipboard

🚀 Feature: Disable email notifications from settings

Open nevo-david opened this issue 1 year ago • 25 comments
trafficstars

🔖 Feature description

Some users might want to opt out of getting emails, we need to allow them.

🎤 Why is this feature needed ?

Some people might not want to get transactional emails

✌️ How do you aim to achieve this?

  • Create a new field in the table User called emailNotifications with a default of true!
  • If it's false, in every function in NotificationService we need to opt them out.
  • Add their feature inside of Settings in the system
  • Add the crud for it inside of settings.controller.ts

🔄️ Additional Information

Make sure it's in the User level and not in the Organization level.

👀 Have you spent some time to check if this feature request has been raised before?

  • [X] I checked and didn't find similar issue

Are you willing to submit PR?

None

nevo-david avatar Mar 19 '24 14:03 nevo-david

@nevo-david can you assign me this issue ?

ishanarora04 avatar Apr 30 '24 05:04 ishanarora04

Hi @ishanarora04, can you let me know once you have successfully deployed your project on your computer? :)

nevo-david avatar Apr 30 '24 06:04 nevo-david

@nevo-david got it running on my local.

ishanarora04 avatar Apr 30 '24 09:04 ishanarora04

Great, assigning this issue to you!

nevo-david avatar Apr 30 '24 12:04 nevo-david

@nevo-david also I saw your Upwork post for a job. Can you hire me ?

ishanarora04 avatar Apr 30 '24 12:04 ishanarora04

Well if you manage to solve this issue, I don't see why not :)

nevo-david avatar Apr 30 '24 12:04 nevo-david

@nevo-david we are looking at Backend Changes only according to above ticket. right ? Also I am assuming we are just stopping the emails, rest all functionality like getting notifications in the notification box remains ?

ishanarora04 avatar May 01 '24 01:05 ishanarora04

@nevo-david any update here ?

ishanarora04 avatar May 01 '24 09:05 ishanarora04

Nope, it's both; why only the backend? @ishanarora04

nevo-david avatar May 02 '24 02:05 nevo-david

can you assign this to me? @nevo-david

nikhilrajbhar17 avatar Sep 11 '24 18:09 nikhilrajbhar17

It looks like @arafat4693 has done the work on this in #176 but the PR never got finished.

It also looks like @ishanarora04 didn't have the time yet to submit changes, so unassigning from them.

Let's wait a couple of weeks to see if @arafat4693 is willing to finish the PR.

jamesread avatar Sep 26 '24 09:09 jamesread

@jamesread Can I attempt?

bansal-harsh-2504 avatar Oct 02 '24 10:10 bansal-harsh-2504

We're still waiting for @arafat4693

jamesread avatar Oct 05 '24 10:10 jamesread

Can I work on this?

hackit-coder avatar Oct 06 '24 14:10 hackit-coder

I fixed the bug long time ago, however, no one merged it

arafat4693 avatar Oct 06 '24 15:10 arafat4693

@arafat4693 it's not finished, the code isn't acceptable at the moment - see Nevo's comments on the PR.

jamesread avatar Oct 06 '24 16:10 jamesread