workspace-images icon indicating copy to clipboard operation
workspace-images copied to clipboard

fix: pacakge manager setup for Node.js

Open gengjiawen opened this issue 3 years ago • 5 comments

Description

Related Issue(s)

Fixes https://github.com/gitpod-io/workspace-images/issues/639

Also fix pnpm setup issue.

How to test

build and test works.

docker build -t test --build-arg base=gitpod/workspace-base --build-arg NODE_VERSION=18.7.0 

I also add test cases in yml too.

Release Notes

Documentation

gengjiawen avatar Aug 22 '22 05:08 gengjiawen

gitpod-io[bot] avatar Aug 22 '22 05:08 gitpod-io[bot]

gitpod-staging[bot] avatar Aug 22 '22 05:08 gitpod-staging[bot]

@kylos101 Can you review this ?

gengjiawen avatar Aug 25 '22 07:08 gengjiawen

@kylos101 Can you review this ?

hi @gengjiawen , can you help us out here to better understand? :pray:

kylos101 avatar Aug 25 '22 16:08 kylos101

Please refer to this matrix for an example. You can see it relates compatible versions of Angular, Node, Typescript, and RxJS. So, users may wish to use nvm to switch between node/npm installations that are coupled to distinct Typescript installations (rather than have Typescript be installed globally across all node/npm versions).

I can revert the typescript part if you like. But I do thinks put typescript in devDependencies is the right thing to do.

If it's desired to use yarn to manage global dependencies

The patch to yarn is mainly to fix https://github.com/gitpod-io/workspace-images/issues/639. Yarn will keep packages global available and work in every conditions.

Also this patch also fix pnpm install global issues.

gengjiawen avatar Sep 04 '22 09:09 gengjiawen

Hi @gengjiawen once this build finishes, there will be new image tag with a timestamp close to "now" which you'll be able to use.

Then, Tuesday, we'll tag the latest images as latest.

kylos101 avatar Oct 09 '22 22:10 kylos101