gitpod-eks-guide icon indicating copy to clipboard operation
gitpod-eks-guide copied to clipboard

Remove ALB Ingress provision and clarify in docs.

Open Pothulapati opened this issue 3 years ago • 2 comments

Description

This PR removes the Ingress (and thus ALB) provision code from the guide to let users do it based on their use-case i.e how they want to expose the proxy svc to the internet with SSL.

In the easiest path, they can just use the proxy service's CLB URL (created by default), and use it everywhere and things would work. (We'll be using whatever certificate config option has, as the SSL cert on the proxy)

This PR also adds a note on how to use SSH gateway stuff when a ALB is used.

Signed-off-by: Tarun Pothulapati [email protected]

Related Issue(s)

Fixes https://github.com/gitpod-io/gitpod/issues/9751

How to test

Release Notes

Remove ALB Ingress provision in the EKS setup

Documentation

Pothulapati avatar May 06 '22 09:05 Pothulapati

At first pass, notes as I try to run this:

  • make build step should be added as just doing make install resulted in a missing certificate_arn error because the image that is in the container registry isn't up to date with the branch
  • we should remove the "Update Gitpod auth providers" section entirely. If you don't set any auth providers, the first time you login to the console you're prompted to manually set one up. That may be a separate issue
  • We should remove this from the addon, we don't need to deploy the ALB since we're not using it and it's one less thing to go wrong - https://github.com/gitpod-io/gitpod-eks-guide/blob/tar/alb-ingress-ssl/lib/addons.ts#L19
  • Docs still mention that we setup / use ALB: https://github.com/gitpod-io/gitpod-eks-guide/blob/1a0424b725e17b47be6430d90634dec1fb43dd29/README.md?plain=1#L56

mrzarquon avatar May 11 '22 07:05 mrzarquon

Excuse me for the unasked feedback, but this PR removes ALB + Certificate but doesn't explain how to configure them if they are needed -> I'd suggest adding a more detailed explanation how to setup ingress clb/alb or both.

I'd be happy to make a documentation PR when this one will be merged but not sure it can happen in May, sorry 😅

HadesArchitect avatar May 12 '22 11:05 HadesArchitect

Closing this PR as we don't plan to merge it. Thanks

Pothulapati avatar Oct 27 '22 12:10 Pothulapati