gitless icon indicating copy to clipboard operation
gitless copied to clipboard

`gl commit -e` conflicts with `git` option

Open techtonik opened this issue 9 years ago • 4 comments
trafficstars

-e option is already taken in git, which may create confusion when switching back and forth. How about -x instead?

techtonik avatar Oct 03 '16 04:10 techtonik

The problem with using -x is that it would break the convention that the short form of an option corresponds to the first letter of its long form (-i is short for --include, -o for --only, and -e for --exclude) and it seems to me that the use of -e in git commit is not as common as to merit breaking the convention due to the clash

spderosso avatar Oct 03 '16 20:10 spderosso

-x is a common convention for various ex commands, so -x for --exclude is also ok.

techtonik avatar Oct 04 '16 08:10 techtonik

Also, hg uses -I and -X switches for that:

 -I --include PATTERN [+] include names matching the given patterns
 -X --exclude PATTERN [+] exclude names matching the given patterns

techtonik avatar Oct 04 '16 08:10 techtonik

Ok, you have convinced me that this is a good idea

spderosso avatar Oct 04 '16 23:10 spderosso