terraform-provider-gitlab icon indicating copy to clipboard operation
terraform-provider-gitlab copied to clipboard

Allow adding groups and users in gitlab_tag_protection

Open r3nic1e opened this issue 3 years ago • 11 comments

Feature Description

gitlab_tag_protection allows only no one, developer or maintainer as create_access_level. But via GitLab we can set custom groups and users there.

gitlab_branch_protection already supports the same: https://github.com/gitlabhq/terraform-provider-gitlab/pull/556

Do you want to implement this?

  • [x] I would like to implement this myself 👷

r3nic1e avatar Jun 21 '22 12:06 r3nic1e

My bad, I haven't check if it is possible to do this via GitLab API. There is no support in API right now https://gitlab.com/gitlab-org/gitlab/-/issues/344520

r3nic1e avatar Jul 04 '22 16:07 r3nic1e

Looks like this functionality is now supported via GitLab API with the 15.2 release.

Implement granular access for Protected Tags API (merge request)

bxscif avatar Jul 25 '22 18:07 bxscif

@bxscif I don't have the time to implement this myself right now, but I'd be super happy to review PRs - in case you are interested!

timofurrer avatar Jul 26 '22 14:07 timofurrer

@bxscif in case you don't have time for this - I can do this

r3nic1e avatar Jul 26 '22 18:07 r3nic1e

@r3nic1e if you're able to, that would be awesome. I'm about to go on vacation and wouldn't be able to get to it for a couple weeks.

bxscif avatar Jul 26 '22 18:07 bxscif

@r3nic1e Yes, of course! 🎉

timofurrer avatar Jul 26 '22 18:07 timofurrer

It's not yet in go-gitlab. So it's kinda blocked right now

r3nic1e avatar Jul 27 '22 08:07 r3nic1e

I might be able to add it there today.

timofurrer avatar Jul 27 '22 08:07 timofurrer

Any update on this?

bxscif avatar Aug 11 '22 16:08 bxscif

I haven't had time unfortunately for that, yet. The offer still stands for a review ...

timofurrer avatar Aug 12 '22 07:08 timofurrer

@timofurrer does that offer for a review stand for me? https://github.com/xanzy/go-gitlab/pull/1540

weirdian2k3 avatar Sep 07 '22 15:09 weirdian2k3