gitlabform icon indicating copy to clipboard operation
gitlabform copied to clipboard

Inheritance break validation function is improperly invalidating

Open ep-linden opened this issue 3 years ago • 2 comments

Describe the bug

Given a config such as this:

projects_and_groups:
  parent/*:
    group_settings:
      description: parent group settings
      project_creation_level: developer

    members:
      enforce: true
      groups:
        group1:
          group_access: developer
        group2:
          group_access: developer
        group3:
          group_access: developer

  commerce/playground/*:
    group_settings:
      description: ''
      project_creation_level: maintainer

    members:
      inherit: false
      enforce: true
      groups:
        group3:
          group_access: maintainer

Since a subgroup is considered both a group and a subgroup, when inherit: false is set under members in the subgroup to break the inheritance from the parent group, the break-inheritance validation function throws an error.

GitLabForm version

🏗 GitLabForm version: 2.11.1 = the latest stable 😊

GitLab version

GitLab Enterprise Edition 14.10.2-ee

ep-linden avatar May 31 '22 22:05 ep-linden

Currently trying to figure out a fix for this.

ep-linden avatar May 31 '22 22:05 ep-linden

Thanks for the fix, @ep-linden ! It has been pre-released in v3 RC3 released today so it also will be fixed in the final v3 that will be released within a few days. We can close this issue then.

gdubicki avatar Jul 06 '22 14:07 gdubicki

Closing as fixed in v3.

gdubicki avatar Aug 27 '22 08:08 gdubicki