Support multiple approval rules

[poffey21]

With GitLab Premium and above, multiple approval rules are supported. Moreover, name-specific rules can be leveraged to create dynamic rules. This rule allows multiple rules to be created:

group_settings:
  'test-group':
    merge_requests:
      approvals:
        approvals_before_merge: 1
        reset_approvals_on_push: true
        disable_overriding_approvers_per_merge_request: true
      approvers:
        - poffey21
      approval_rules:
        Vulnerability-Check:
          approvers:
          - poffey21

or

group_settings:
  'test-group':
    merge_requests:
      approvals:
        approvals_before_merge: 1
        reset_approvals_on_push: true
        disable_overriding_approvers_per_merge_request: true
      approvers:
        - poffey21
      approval_rules:
        Vulnerability-Check:
          approvers:
          - poffey21

or

group_settings:
  'test-group':
    merge_requests:
      approvals:
        approvals_before_merge: 1
        reset_approvals_on_push: true
        disable_overriding_approvers_per_merge_request: true
      approval_rules:
        Vulnerability-Check:
          approvers:
          - poffey21

[gdubicki]

(This would implement #95.)

[gdubicki]

Hey @poffey21 , thanks a lot for the contribution! 😊🙏

[gdubicki]

Hey @poffey21 ! Is there a chance you will get back to this PR and continue working on it? Please answer honestly as maybe we can open this for other people to continue.

[poffey21]

@gdubicki I will pick this back up this upcoming week. Thanks for the ping!

[mahparaashley]

@gdubicki @poffey21 when would this feature be available for use? We planning to use multi-approval rules for few of our repos. Thank you for your contribution :).

[Siythrun]

Is there any more traction on this change? Would be good to see approvals_required and approver_groups added to this as well.

[gdubicki]

Frankly we don't have a Premium GitLab license so we are not highly motivated to implement it ourselves, @Siythrun . We are open to PRs though!

[vchepkov]

This was open for more than a year, I would be happy to test, since we use EE edition. Github shows me no changes though

[gdubicki]

This was open for more than a year, I would be happy to test, since we use EE edition. Github shows me no changes though

I think you would have to go through each commit here, check its diff and possibly cherry-pick what is good to another branch.

[yashwanth-l]

any timeline on when this feature would be available with gitlabform?

[gdubicki]

@yashwanth-l: as mentioned in https://github.com/gitlabform/gitlabform/issues/388, in September I will have access to license that supports multiple approval rules. Then I can and most probably will implement this feature on my own as this is something that we would need ourselves at Egnyte. So it should be released in September/October.

[gdubicki]

Closing as outdated, but thanks for your work on this anyway, @poffey21! I will create a new PR in its place.