vscode-gitlens icon indicating copy to clipboard operation
vscode-gitlens copied to clipboard

Fix focus before show quick commit popup

Open quyenvsp opened this issue 2 years ago • 2 comments

Description

Fix https://github.com/gitkraken/vscode-gitlens/issues/2906

Because quick commit popup show when click A tag on hovering line popup, vscode do not know what should be focus. So we need hide hovering line popup before show quick commit popup.

Checklist

  • [x] I have followed the guidelines in the Contributing document
  • [x] My changes follow the coding style of this project
  • [x] My changes build without any errors or warnings
  • [x] My changes have been formatted and linted
  • [x] My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • [x] My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • [x] My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

quyenvsp avatar Sep 20 '23 04:09 quyenvsp

@eamodio Hi, could you review it?

quyenvsp avatar Sep 28 '23 03:09 quyenvsp

Sorry for the delay. I can't reproduce this issue but it must be a VS Code bug of some kind. Since this "fix" is a hack to workaround that bug and that it is forcing focus to something that may or may not have focus, I don't think GitLens should attempt to fix it. Forcing focus to the active editor group, could have implications to keyboard usage and screen reader support.

eamodio avatar Nov 27 '23 05:11 eamodio