gitify icon indicating copy to clipboard operation
gitify copied to clipboard

feat: support grouping notifications by date or repository

Open AltinGruda opened this issue 1 year ago • 12 comments
trafficstars

Added a dropdown menu to group notifications by date or repository. UI changes were made based on how it looks on https://github.com/notifications

closes #836

AltinGruda avatar Mar 03 '24 21:03 AltinGruda

Thanks for the contribution @AltinGruda. Functionally it seems to do the trick.

I'm wondering whether the toggle should either be in the Settings menu, or, on the left-hand-side, perhaps below the notification count bell.

@brandonweiss @afonsojramos - what do you both think?

setchy avatar Mar 03 '24 21:03 setchy

I thought of putting it in the sidebar below the notification bell icon, with the icon shown below. Let me know what you guys think. image

AltinGruda avatar Mar 03 '24 22:03 AltinGruda

I thought of putting it in the sidebar below the notification bell icon, with the icon shown below. Let me know what you guys think. image

Let's see what that looks like

setchy avatar Mar 04 '24 00:03 setchy

This is how it looks with the dropdown being below the notification icon.

image image

AltinGruda avatar Mar 04 '24 13:03 AltinGruda

Thanks @AltinGruda - certainly looks better on the left side.

A suggestion I'd appreciate feedback on... What if instead of the drop-down we simply toggled between two icons, with suitable hover text?

setchy avatar Mar 05 '24 14:03 setchy

What if instead of the drop-down we simply toggled between two icons, with suitable hover text?

@setchy, I understand where you're coming from, but in filters world, that is not a common UX practice, and thus, I would stay away from it.

afonsojramos avatar Mar 05 '24 18:03 afonsojramos

What if instead of the drop-down we simply toggled between two icons, with suitable hover text?

@setchy, I understand where you're coming from, but in filters world, that is not a common UX practice, and thus, I would stay away from it.

To me, it's really just a yes / no group by repository, not filtering at all :)

If we're not keen on that, perhaps we add it into the Settings menu along with our other options.

setchy avatar Mar 05 '24 18:03 setchy

Right, but in the future maybe we will implement other sorting/grouping capabilities within the same menu, hence why I think the way it is looks better

afonsojramos avatar Mar 05 '24 19:03 afonsojramos

I've considered the suggestion to turn the filter into a toggle and created a preview (screenshots attached, have not pushed the changes). While toggles can offer a clear interface, I'm open to feedback on whether this aligns with our UX goals or if there are better alternatives.

image image

AltinGruda avatar Mar 05 '24 19:03 AltinGruda

Are we sticking with the dropdown or the toggle one?

AltinGruda avatar Mar 09 '24 15:03 AltinGruda

I'd go with the dropdown, but the implementation needs fixing. Clicking outside of the dropdown should close the dropdown, not block the whole app from interaction.

afonsojramos avatar Mar 11 '24 17:03 afonsojramos

I went ahead and implemented the functionality to close the dropdown when clicking outside of it. The issue where clicking outside the whole app closes seems to be on the main branch as well, so I dont think I caused that issue

AltinGruda avatar Mar 11 '24 22:03 AltinGruda