gitify
gitify copied to clipboard
Hotfix missing discussion items url
I'm aware it's not super clean, but it does the trick until Github fix its REST API (see #424). If so, the first test will pass and this code will never reach out again and we will be able to remove it without second thought 😉
Again, it's just an idea for the mean time, feel free to say that it's a bad idea. I didn't update the test due to the very “temporary” aspect of this code, but I can do so if needed.
What's the status of this? I'd really like to be able to click notifications to open discussions.
I'll do the cleanup asap 😉
Looking forward to this enhancement. Thanks @Yago for contributing this PR
@manosim - do you think this enhancement is ready to merge and release?
we can get the Discussion thread url using GraphQL search
I have created a repo to easily test this: https://github.com/Araxeus/github_discussion_notification_url
Any thoughts? (the graphQL query logic is exclusively in https://github.com/Araxeus/github_discussion_notification_url/blob/main/graphql.js)
EDIT: I've opened a PR #538 which uses that logic and in case it fails, defaults to the the method here
Will merge #538 over this one. Thank you to everyone involved!!!