Mitigate API hammering with high notification counts

[grahamj]

trafficstars

Hi, you might remember me from such feature suggestions as https://github.com/gitify-app/gitify/issues/1857

Long story short, today we figured out that my use of Gitify has been bringing my team's GHE to its knees 🐼 For a 1-minute period I see Gitify requesting many pages of notifications and then close to 300 each of pulls and reviews. Root cause is I don't clear out old merged PR notifications because I use Gitify which helpfully filters them.

Now I realize this is what it's supposed to do and it's my bad for not cleaning up my notifications. But in my defence:

• The vast majority of those 300 PRs are merged
• Thanks to your gracious addition of merged filtering I never see them in Gitify
• The main reason I use Gitify is to avoid GH notifications because it doesn't do that filtering

I don't think the notifications API provides PR status so avoiding the /pulls is probably impossible. But a couple of other possibilities that come to mind are:

• Option to automatically mark filtered notifications as read
• ~~Option to limit considered notifications by number or time~~
• Configurable API call rate limiting
• Even if /pulls is necessary maybe don't grab /reviews for filtered PRs

I guess this is more of a discussion starter than request per se. Thanks for Gitify!

[setchy]

A great discussion to have - thanks for starting it @grahamj.

Option to limit considered notifications by number or time

To confirm, I assume this option doesn't meet your needs / workflow?

[setchy]

Even if /pulls is necessary maybe don't grab /reviews for filtered PRs

This is a good suggestion, though could be tricky to implement. At the moment the filtering occurs as a post processing step once the raw notifications have been enriched, since some of the filters are actually derived values.

[grahamj]

A great discussion to have - thanks for starting it @grahamj.

Option to limit considered notifications by number or time

To confirm, I assume this option doesn't meet your needs / workflow?

sigh I did not notice that option, sorry 🤦🏻‍♂️ That combined with staying on top of my GH notifications should solve the issue for me.

The other ideas might be worth considering anyway though.

[setchy]

API call volumes reduces via #2156 and #2158. Happy to reopen this issue if there are further opportunities

[setchy]

@grahamj - appreciate your feedback re v6.6.0 and if that helps your situation