gitify icon indicating copy to clipboard operation
gitify copied to clipboard

feat: reset to default settings

Open setchy opened this issue 1 year ago • 4 comments
trafficstars

Add a reset default settings option. Of increasing usefulness as we've been adding, and may continue to add more settings in future.

Screenshot 2024-06-28 at 8 14 28 AM

setchy avatar Jun 28 '24 15:06 setchy

I perceive that icon as "undo my last change," not "undo all changes, ever." I could, therefore, click it and get effective data loss without intending...

bmulholland avatar Jul 01 '24 09:07 bmulholland

Is there an alternative icon you'd propose - https://primer.style/foundations/icons?

Would there be a different location you'd prefer?

I figured the hover text was enough 🤷‍♂️

setchy avatar Jul 01 '24 12:07 setchy

I'd argue more against the feature, than the icon itself. Why would we want this?

(But if we really want this, I'd say actual text aligned to the right saying "Reset to defaults *currentUndoIconHere*")

afonsojramos avatar Jul 01 '24 23:07 afonsojramos

I'd argue more against the feature, than the icon itself. Why would we want this?

I was a little unclear in my PR, apologies.

I think this could be helpful for users who may have tinkered with settings and want to revert back to the out-of-the-box / default combination of settings that we recommend, especially as our feature-set continues to evolve.

(But if we really want this, I'd say actual text aligned to the right saying "Reset to defaults currentUndoIconHere")

How about this 😎 - update pushed to branch

Screenshot 2024-07-03 at 6 08 25 PM

setchy avatar Jul 04 '24 02:07 setchy

@setchy took the liberty to push to this branch the option I think is the most viable. Hope that's okay.

Let me know what you think! image

afonsojramos avatar Jul 05 '24 17:07 afonsojramos

Works for me

setchy avatar Jul 05 '24 18:07 setchy

I think it is a bit more clear right out of the gate and it's only visible if you're looking for it. Which, for a "deep" setting, makes sense!

afonsojramos avatar Jul 05 '24 18:07 afonsojramos