vscode-github-actions icon indicating copy to clipboard operation
vscode-github-actions copied to clipboard

Try to auto-detect which remote points to github.com

Open sarisia opened this issue 2 years ago • 9 comments

Is your feature request related to a problem? Please describe.

The extension couldn't find GitHub repository for the git repository when both of the following conditions are met:

  • git repository has two remotes
  • github url is not set as origin remote

i.e.:

$ git remote -v
github  https://github.com/my-org/my-repo.git (fetch)
github  https://github.com/my-org/my-repo.git (push)
origin  https://internal-scm.example.com/my-repo.git (fetch)
origin  https://internal-scm.example.com/my-repo.git (push)

Describe the solution you'd like Let the extension detect GitHub repository from all the remotes, not only from origin.

Additional context

AFAIK GitHub CLI supports this scenario.

sarisia avatar Mar 29 '23 02:03 sarisia

I found the configuration github-actions.remote-name it works, but still think supporting auto-detection would be helpful.

sarisia avatar Mar 29 '23 08:03 sarisia

Thank you. I've updated the title slightly to reflect this.

cschleiden avatar Mar 31 '23 18:03 cschleiden

@sarisia / @cschleiden, would you please attach the steps on how to get to the configuration and change it? Thanks!

shirady avatar Apr 04 '23 05:04 shirady

https://github.com/github/vscode-github-actions/issues/50#issuecomment-1495360003 @sarisia / @cschleiden, would you please attach the steps on how to get to the configuration and change it? Thanks!

  1. Open VSCode settings

    image

  2. Search for github-actions.remote-name

    image

sarisia avatar Apr 04 '23 05:04 sarisia

@sarisia, thank you!

shirady avatar Apr 04 '23 05:04 shirady

The latest release may fix this, though its possible there's more work to be done there, can you try it and let me know?

felipesu19 avatar May 15 '23 20:05 felipesu19

@felipesu19 Thank you for looking into this! Unfortunatelly, it's still not working.. (v0.25.7)

sarisia avatar May 16 '23 01:05 sarisia

Thank you for trying! i'll move it into issues to triage then!

felipesu19 avatar May 18 '23 16:05 felipesu19