vscode-github-actions icon indicating copy to clipboard operation
vscode-github-actions copied to clipboard

Expression syntax highlighting doesn't seem to respect comments

Open max-sixty opened this issue 2 years ago • 3 comments

Describe the bug

Here, this line should appear as a comment:

image

To Reproduce

Here's the text:

  update-rust-toolchain:
    runs-on: ubuntu-latest
    # Don't run on forks; will attempt to create a PR into the fork...

    # if: ${{ !github.event.pull_request.head.repo.fork }}

Extension Version v0.25.6

max-sixty avatar Apr 29 '23 23:04 max-sixty

Currently we always syntax highlight expressions in comments, that's not just limited to if expressions. It's due to the way we inject into the yaml grammar.

Since adding GitHub Actions Workflows as a separate language we could modify the yaml tm grammar if we wanted to.

cschleiden avatar May 08 '23 21:05 cschleiden

Since adding GitHub Actions Workflows as a separate workflow we could modify the yaml tm grammar if we wanted to.

Did you mean "as a separate language"?

muzimuzhi avatar May 09 '23 15:05 muzimuzhi

I noticed this as well, this just looks odd:

image

The entire comment should be shown in green, in my opinion.

scott-doyland-burrows avatar May 31 '23 13:05 scott-doyland-burrows