vscode-github-actions
vscode-github-actions copied to clipboard
Expression syntax highlighting doesn't seem to respect comments
Describe the bug
Here, this line should appear as a comment:
To Reproduce
Here's the text:
update-rust-toolchain:
runs-on: ubuntu-latest
# Don't run on forks; will attempt to create a PR into the fork...
# if: ${{ !github.event.pull_request.head.repo.fork }}
Extension Version
v0.25.6
Currently we always syntax highlight expressions in comments, that's not just limited to if expressions. It's due to the way we inject into the yaml grammar.
Since adding GitHub Actions Workflows as a separate language we could modify the yaml tm grammar if we wanted to.
Since adding
GitHub Actions Workflowsas a separate workflow we could modify the yaml tm grammar if we wanted to.
Did you mean "as a separate language"?
I noticed this as well, this just looks odd:
The entire comment should be shown in green, in my opinion.