markup icon indicating copy to clipboard operation
markup copied to clipboard

README.pod symlink to Perl module renders incorrectly

Open kiwiroy opened this issue 6 years ago • 18 comments

Opening a new issue in an attempt to shine some light on my last comment in #1158 and the behaviour observed rendering the README.pod here. I have a mixture of private repositories using the same technique that have a mix of success and failure in displaying the expected result and a minimal example of success here

The symlinks are detected as POD as reported here.

Running locally github-markup, pod2html converts as expected:

$ git rev-parse --short HEAD
8f436ff
$ bundle show | grep linguist
  * github-linguist (7.1.3)
$ bundle exec bin/github-markup ../applify/README.pod | head
<h1 id="NAME">NAME</h1>

<p>Applify - Write object oriented scripts with ease</p>

<h1 id="VERSION">VERSION</h1>

<p>0.15</p>

<h1 id="DESCRIPTION">DESCRIPTION</h1>
$ perl -v | head -n2 | tail -n1
This is perl 5, version 26, subversion 2 (v5.26.2) built for darwin-thread-multi-2level

I did some sanity checking in linguist with additional tests, they all passed.

kiwiroy avatar Jan 23 '19 12:01 kiwiroy

I did some sanity checking in linguist with additional tests, they all passed.

Travis disagreed, but has since been convinced.

Investigating further in the simple repository listed above it is difficult to explain the results of the following three:

Could pod2html be failing occasionally, for some reason and consequently content is passed through in render: https://github.com/github/markup/blob/de903b8c5abb1ec46a750350560ad7f1888bee30/lib/github/markup/command_implementation.rb#L25-L29

kiwiroy avatar Jan 25 '19 09:01 kiwiroy

I've also experienced this issue.

With no changes by me, my repos have gone from looking like this:

screen shot 2019-02-19 at 9 58 31 am

to looking like this:

screen shot 2019-02-19 at 9 58 47 am

symkat avatar Feb 19 '19 18:02 symkat

This is also affecting my repos. At first I thought it might be a result of the age of the code, but I ran it through github-markup and the results were fine. This is really frustrating...

aarondcohen avatar Jul 19 '19 16:07 aarondcohen

I've been trying to narrow this down to the smallest valid test case I can write and this is the best I've come up with so far.

This will render correctly:

=encoding UTF-8

=head1 NAME

=head1 FOO

This won't:

=encoding UTF-8

=head1 NAMD

=head1 FOO

I can't explain it.

MCRayRay avatar Oct 13 '19 12:10 MCRayRay

Having exact same issue with symlinks to PODs, it works in one case, it doesn't in another.

ANSI-C avatar Jul 06 '20 21:07 ANSI-C

Can we split it

On Mon, Jul 6, 2020, 5:43 PM Anselmo Canfora [email protected] wrote:

Having exact same issue with symlinks to PODs, it works in one case, it doesn't in another.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/github/markup/issues/1253#issuecomment-654480624, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFURVOVKR3YVJNM6F6CPQ3R2JARDANCNFSM4GR25FVA .

Shelly1973 avatar Jul 07 '20 01:07 Shelly1973

Can we split it On Mon, Jul 6, 2020, 5:43 PM Anselmo Canfora @.***> wrote: Having exact same issue with symlinks to PODs, it works in one case, it doesn't in another. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1253 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFURVOVKR3YVJNM6F6CPQ3R2JARDANCNFSM4GR25FVA . https://github.com/github/markup/issues/1253#issuecomment-654480624

Shelly1973 avatar Jul 07 '20 01:07 Shelly1973

Here is a rather interesting data point: ap/Catalyst-View-Template@6318f66

I have a README.pod there which is failing to render… but this one doesn’t link to a .pm file. Instead I put the documentation in a separate .pod file and symlinked that – specifically to try and sidestep this bug. It seemed so obvious that this would work that I didn’t even do an experiment to verify before I used it. But it turns out that even this can fail.

Hopefully this is a new clue into the mystery of what is causing this bug… rather than an entirely separate second(ary) bug. Maybe it gives someone who has investigated this bug a lightbulb moment?

ap avatar Oct 24 '20 18:10 ap

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 28 '24 12:11 github-actions[bot]

This bug continues to be present and it continues to be a problem. It has not magically gone away just because nobody fixed it in the meantime.

ap avatar Nov 28 '24 12:11 ap

This bug continues to be present and it continues to be a problem. It has not magically gone away just because nobody fixed it in the meantime.

Codeberg?

ANSI-C avatar Nov 28 '24 13:11 ANSI-C

Codeberg?

ap avatar Nov 28 '24 15:11 ap

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jan 29 '25 12:01 github-actions[bot]

This is still a problem; please keep this open.

karenetheridge avatar Jan 29 '25 18:01 karenetheridge

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 31 '25 12:03 github-actions[bot]

Here’s some further activity then.

ap avatar Mar 31 '25 23:03 ap

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 01 '25 12:06 github-actions[bot]

This remains an issue.

ap avatar Jun 01 '25 12:06 ap

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 01 '25 12:08 github-actions[bot]

This remains an issue.

karenetheridge avatar Aug 01 '25 15:08 karenetheridge

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 01 '25 12:10 github-actions[bot]

This remains an issue.

ap avatar Oct 01 '25 16:10 ap

This issue remains unresolved.

ap avatar Nov 30 '25 18:11 ap