markdown-toolbar-element

markdown-toolbar-element copied to clipboard

Added Table support

1

mirandarfsm

Just as we set the `role=button` for the markdown buttons: https://github.com/github/markdown-toolbar-element/blob/731b52a7e400260a693ff745ddf3e5984a42b411/src/index.ts#L100-L102 We should also give them [discernible text][1] if it's not already set. [1]: https://dequeuniversity.com/rules/axe/4.0/button-name?application=axeAPI

koddsson

Hotkeys don't work on Windows with non en-us keyboard layout

1

Current way of matching hotkey with `event.key` property leads to broken hotkeys on Windows (Chrome, Vivaldi at least) as, for example with ru-RU locale on keybord hitting cmd+b will send...

Reeywhaar

``` SyntaxError: Failed to execute 'querySelector' on 'Element': '[hotkey="""]' is not a valid selector. ``` https://github.com/github/markdown-toolbar-element/blob/c3630f64cddd29a98bb8b03965e9baa83f585dc4/index.js#L230

mislav

Element should not auto-register itself unless a browser context is found

8

Per discussion in https://github.com/primer/react/pull/2339, the fact that this element automatically registers itself at the top level makes it incompatible with server-side rendering, where JavaScript might be run outside of a...

iansan5653

The `role` code is never executed in base `MarkdownButtonElement`

2

The `role` code is never executed in base `MarkdownButtonElement` ``` connectedCallback() { if (!this.hasAttribute('role')) { this.setAttribute('role', 'button'); } } ``` Because other classes like `MarkdownHeaderButtonElement extends MarkdownButtonElement` never call parent...

wxiaoguang