gh-ost icon indicating copy to clipboard operation
gh-ost copied to clipboard

Double the time waiting post replication restart

Open andyedison opened this issue 1 year ago • 1 comments

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs. If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues, and potentially we'll be able to point development in a particular direction.

Related issue:

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR increases the startSlavePostWaitMilliseconds as we are seeing an error when running gh-ost in some cloud environments that the Slave_IO_Running is Connecting rather than Yes as expected.

We found this old PR that described the issue we're having https://github.com/github/gh-ost/pull/337 - as a first step we are increasing by doubling the value. If this test is successful, then we'll look into making this something that could be configured.

In case this PR introduced Go code changes:

  • [ ] contributed code is using same conventions as original code
  • [ ] script/cibuild returns with no formatting errors, build errors or unit test errors.

andyedison avatar Jun 11 '24 19:06 andyedison

Targeted the wrong branch > will use https://github.com/github/gh-ost/pull/1422

andyedison avatar Jun 11 '24 19:06 andyedison

Closing in favor of https://github.com/github/gh-ost/pull/1422

meiji163 avatar Dec 17 '24 03:12 meiji163