gh-gei icon indicating copy to clipboard operation
gh-gei copied to clipboard

Published 20 hours ago • verified publisher icon github

Retry GHES archive generation

Open dylan-smith opened this issue 3 years ago • 1 comments

We've been seeing a bunch of integration test failures when generating GHES archives. Usually the error is something like the connection was closed, or other networking sounding errors.

We could probably do a retry on archive generation if it fails for any reason.

dylan-smith avatar Aug 31 '22 19:08 dylan-smith

We have already added retries on HTTP failures. But sometime the archive generation might fail, but GHES returns an HTTP 200 with a message telling us the archive generation failed. In that case we should restart the archive generation again.

dylan-smith avatar Sep 14 '22 17:09 dylan-smith

This issue was mentioned in FastTrack's CarMax trip report.

timrogers avatar Feb 20 '23 14:02 timrogers

I don't think the PR does what this issue intended.

The intent behind the issue was that if archive generation fails for pretty much any reason (network error, GHES says it failed on it's side, etc), the CLI would just start the whole archive generation process over. And it would do that 5 times before finally giving up. However, with that PR's change I think all that happens is if GHES returns the FAILED status code, the CLI will retry the GetMigrationStatus api call a few times (presumably always getting the same Migration_Failed response).

I'm going to re-open this Issue.

dylan-smith avatar Mar 24 '23 17:03 dylan-smith