docs icon indicating copy to clipboard operation
docs copied to clipboard

Broken Markup fixed

Open codewithdev opened this issue 3 years ago â€ĸ 3 comments

Why:

Closes #21606

What's being changed (if available, include any code snippets, screenshots, or gifs):

image Wrapped the command with reusables {% raw %}/ {% endraw %}

Check off the following:

  • [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

codewithdev avatar Oct 30 '22 19:10 codewithdev

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: .devcontainer/** .github/actions-scripts/** .github/workflows/** .github/CODEOWNERS assets/fonts/** data/graphql/** Dockerfile* lib/graphql/** lib/redirects/** lib/rest/** lib/webhooks/** lib/search/indexes/** package*.json scripts/** translations/** content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

github-actions[bot] avatar Oct 30 '22 19:10 github-actions[bot]

Automatically generated comment â„šī¸

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-cloud-providers.md fpt
ghec
ghes@ 3.7 3.6 3.5
fpt
ghec
ghes@ 3.7 3.6 3.5

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Oct 30 '22 19:10 github-actions[bot]

@codewithdev Thanks so much for opening a PR! I'll get this triaged for review :zap:

cmwilson21 avatar Oct 31 '22 13:10 cmwilson21

It looks like we prevent changes to this file for security reasons 🤔 I'm pinging in the leads for this area to see if we can override this check or need to make the change internally instead: @martin389 @dihydroJenoxide

skedwards88 avatar Oct 31 '22 20:10 skedwards88

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: .devcontainer/** .github/actions-scripts/** .github/workflows/** .github/CODEOWNERS assets/fonts/** data/graphql/** Dockerfile* lib/graphql/** lib/redirects/** lib/rest/** lib/webhooks/** lib/search/indexes/** package*.json scripts/** translations/** content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

github-actions[bot] avatar Nov 07 '22 04:11 github-actions[bot]

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Nov 07 '22 06:11 github-actions[bot]