codeql icon indicating copy to clipboard operation
codeql copied to clipboard

Published 20 hours ago • verified publisher icon github

Python: Add dataflow consistency query

Open RasmusWL opened this issue 3 years ago • 2 comments
trafficstars

As a real consistency query, so it will be run as part of ALL tests. (which might make CI take longer, but the value is nice I think)

I've made a dummy consistency query in https://github.com/github/codeql/pull/8458 to convince reviewers that these consistency queries are actually run :blush:

RasmusWL avatar Mar 16 '22 08:03 RasmusWL

AHA, a few inconsistencies uncovered :detective: @yoff maybe we can work together on fixing these?

RasmusWL avatar Mar 16 '22 10:03 RasmusWL

Interesting. There are a few instances of Node has multiple PostUpdateNodes. The rest are missing toStrings.

yoff avatar Sep 23 '22 13:09 yoff

It seems we have very few failure modes:

  • Call should have one enclosing callable but has 0. (Lots)
  • Node steps to itself (Lots)
  • Store step does not preserve enclosing callable. (Just a few)

I wonder what is going on here? We should not have semantic changes, should we? Is this to do with the missing file?

yoff avatar Aug 24 '23 07:08 yoff

I wonder what is going on here? We should not have semantic changes, should we? Is this to do with the missing file?

same problem as https://github.com/github/codeql/pull/14037

RasmusWL avatar Aug 24 '23 08:08 RasmusWL

same problem as #1403

Ah, so updating should fix it.

yoff avatar Aug 24 '23 09:08 yoff

woops, git merge did things to C++ which was certainly not intended

RasmusWL avatar Nov 21 '23 10:11 RasmusWL