codeql
codeql copied to clipboard
github
C++: Do not generate IR for functions with multiple entry points
Pull Request checklist
All query authors
- [ ] A change note is added if necessary. See the documentation in this repository.
- [ ] All new queries have appropriate
.qhelp. See the documentation in this repository. - [ ] QL tests are added if necessary. See Testing custom queries in the GitHub documentation.
- [ ] New and changed queries have correct query metadata. See the documentation in this repository.
Internal query authors only
- [ ] Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to
.ql,.qll, or.qhelpfiles. See the documentation (internal access required). - [ ] Changes are validated at scale (internal access required).
- [ ] Adding a new query? Consider also adding the query to autofix.
The DCA looks like it's gotten quite stuck. I just merged https://github.com/github/codeql-dca/pull/2274, so you can re-run it and try out the new nightly-buildless.yml source suite. I recommend using the latest main in semmle-code as that also has various BMN fixes. There may still be some timeouts ("No source found"), which could be rescued by re-running the job.
I'm currently fixing the No source found error, so we are close to having a working and actually usable DCA suite!
Let's wait until we have a fix for the "No source found" issue. Then, I'll rebase and we can try again.
The (potential) fix is here: https://github.com/github/semmle-code/pull/51475
DCA has just started so we'll need to wait for that.
We lose quite a lot of results in buildless
The question is whether those "results" were actually results, or just very confusing non-results. In a lot of cases I expect the latter, but this needs to be properly measured.