codeql icon indicating copy to clipboard operation
codeql copied to clipboard

C#: Lift models.

Open michaelnebel opened this issue 1 year ago • 1 comments

In this PR we align the C# model generator lifting and override logic with Java. That is,

  • Models are now lifted to the top base class within the source code. However, we exclude Object and ValueType as this causes issues when generating models for .NET runtime (as these class definitions are included in the .NET runtime source code).
  • The extensible logic is changed; We now say that models should apply to all overrides with the exception of overrides of methods defined on Object and ValueType (as class or value type implicitly extend these).

Furthermore, we also make a small fix related to sink model discovery. We only want to exclude generation of these, if there exist a neutral sink model (and not a neutral summary model).

michaelnebel avatar May 14 '24 08:05 michaelnebel

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. A recent commit removed the previously reported differences.

github-actions[bot] avatar May 16 '24 11:05 github-actions[bot]