codeql icon indicating copy to clipboard operation
codeql copied to clipboard

Published 20 hours ago • verified publisher icon github

C#: Remove `AddLocalSource` classes from queries

Open egregius313 opened this issue 1 year ago • 3 comments
trafficstars

The AddLocalSource classes were added in https://github.com/github/codeql/pull/15419 to make deprecating LocalSource classes easier.

This removes them so that queries rely on ThreatModelFlowSource.

egregius313 avatar Feb 28 '24 18:02 egregius313

The comments on the PR that this PR is based on needs to be addressed, which implies further changes as a part of this PR. This PR also needs the part of the change note that is removed from the other PR.

michaelnebel avatar Feb 29 '24 08:02 michaelnebel

@egregius313 : Lets also run DCA (I will trigger a run).

michaelnebel avatar Mar 04 '24 12:03 michaelnebel

DCA: (1) Performance looks good. (2) We loose a couple of results, which could be expected as we now don't consider local sources for some of the queries. The lost results all read their input from the Console (local user input), which is as expected.

This is ready to be merged as soon as the relase for 2.16.4 has completed.

michaelnebel avatar Mar 05 '24 08:03 michaelnebel