codeql
codeql copied to clipboard
python: Rewrite `HardcodedCredentials` away from `PointsTo`
trafficstars
ModuleValue.attrandClassValue.lookupare approximated byFunction.getNameClassValue.getNameis apprximated byClass.getNameModule::namedis approximated byModule.getNameValue::namedis approximated byBuiltins::likelyBuiltinFunctionValue.getNamedArgumentForCallis approximated byArgumentNode.argumentOf
As far as I can tell from the evaluation, it gets slightly more noisy, adding 21 alerts and losing 14. All of the added and lost alerts seem to be false positives, it is not really better or worse precision-wise. It is a massive improvement, though, to not have to run the PointsTo computation in the securty-extended suite. So for this reason, I propose to take this rewrite as is. If we get many more false positive reports, we will perhaps be pushed to rewrite the query based on fewer heuristics, as we have discussed a few times.