codeql icon indicating copy to clipboard operation
codeql copied to clipboard

Java: Add support for java.util.StringJoiner

Open pwntester opened this issue 3 years ago • 7 comments
trafficstars

pwntester avatar Sep 22 '22 11:09 pwntester

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,3,585,130,28,,,7,,,10
+    Java Standard Library,``java.*``,3,588,130,28,,,7,,,10
-    Totals,,217,8428,1524,129,6,10,107,33,1,86
+    Totals,,217,8431,1524,129,6,10,107,33,1,86
  • Changes to framework-coverage-java.csv:
- java.util,44,,461,,,,,,,,,,,34,,,,,,5,2,,1,2,,,,,,,,,,,,,,36,425
+ java.util,44,,464,,,,,,,,,,,34,,,,,,5,2,,1,2,,,,,,,,,,,,,,39,425

github-actions[bot] avatar Sep 22 '22 12:09 github-actions[bot]

Hey @pwntester, thanks for this! I added some more CSV rows for the fluent methods of StringJoiner, tests, and a change note.

atorralba avatar Sep 22 '22 17:09 atorralba

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,3,585,130,28,,,7,,,10
+    Java Standard Library,``java.*``,3,591,130,28,,,7,,,10
-    Totals,,217,8428,1524,129,6,10,107,33,1,86
+    Totals,,217,8434,1524,129,6,10,107,33,1,86
  • Changes to framework-coverage-java.csv:
- java.util,44,,461,,,,,,,,,,,34,,,,,,5,2,,1,2,,,,,,,,,,,,,,36,425
+ java.util,44,,467,,,,,,,,,,,34,,,,,,5,2,,1,2,,,,,,,,,,,,,,39,428

github-actions[bot] avatar Sep 22 '22 17:09 github-actions[bot]

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,3,585,130,28,,,7,,,10
+    Java Standard Library,``java.*``,3,592,130,28,,,7,,,10
-    Totals,,217,8428,1524,129,6,10,107,33,1,86
+    Totals,,217,8435,1524,129,6,10,107,33,1,86
  • Changes to framework-coverage-java.csv:
- java.util,44,,461,,,,,,,,,,,34,,,,,,5,2,,1,2,,,,,,,,,,,,,,36,425
+ java.util,44,,468,,,,,,,,,,,34,,,,,,5,2,,1,2,,,,,,,,,,,,,,40,428

github-actions[bot] avatar Sep 22 '22 18:09 github-actions[bot]

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,3,585,130,28,,,7,,,10
+    Java Standard Library,``java.*``,3,593,130,28,,,7,,,10
-    Totals,,217,8428,1524,129,6,10,107,33,1,86
+    Totals,,217,8436,1524,129,6,10,107,33,1,86
  • Changes to framework-coverage-java.csv:
- java.util,44,,461,,,,,,,,,,,34,,,,,,5,2,,1,2,,,,,,,,,,,,,,36,425
+ java.util,44,,469,,,,,,,,,,,34,,,,,,5,2,,1,2,,,,,,,,,,,,,,41,428

github-actions[bot] avatar Sep 23 '22 07:09 github-actions[bot]

Thanks @Marcono1234, those are good suggestions. I had doubts about setEmptyValue and that's why I didn't add it in the first place, but even if taint would only get propagated in certain cases (when no other strings are joined) I guess it makes sense to have the model.

Applied in e849acb.

atorralba avatar Sep 23 '22 07:09 atorralba

:warning: The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,3,585,130,28,,,7,,,10
+    Java Standard Library,``java.*``,3,593,130,28,,,7,,,10
-    Totals,,217,8428,1524,129,6,10,107,33,1,86
+    Totals,,217,8436,1524,129,6,10,107,33,1,86
  • Changes to framework-coverage-java.csv:
- java.util,44,,461,,,,,,,,,,,34,,,,,,5,2,,1,2,,,,,,,,,,,,,,36,425
+ java.util,44,,469,,,,,,,,,,,34,,,,,,5,2,,1,2,,,,,,,,,,,,,,41,428

github-actions[bot] avatar Sep 27 '22 07:09 github-actions[bot]