codeql
codeql copied to clipboard
Java: Android deeplink analysis
trafficstars
Summary: This PR adds flow steps to model the routing aspect of a deeplink-handling Android component (i.e. wire the Intent being sent from the deeplink router to its destination).
Description:
- Updated the existing
StartActivityIntentStepstep to handle anIntentconstructor with four arguments. Also added morestartActivitymethods. - Added steps for services and receivers.
Consideration:
- The expectation comments for the tests are very lengthy due to how I used the expected-value tag. Let me know if there is a more concise way to structure these tests to avoid the lengthy comment.
- I updated a few QLDocs in the
Intent.qllfile to be in line with the QLDocs style guide which states: "For single-line documentation, the/**and*/are written on the same line as the comment". Let me know if these updates should not be included in this PR. - Is there anything else to consider with the logic or code design?
Thanks @atorralba! Updates made in commit b4e8e97.