gitbutler icon indicating copy to clipboard operation
gitbutler copied to clipboard

Support using 1password managed ssh keys

Open krlvi opened this issue 1 year ago • 4 comments

discord discussion https://discord.com/channels/1060193121130000425/1208456893383577671/1208510948516696155

krlvi avatar Feb 17 '24 16:02 krlvi

Came to make just this issue. For reference, this is the relevant(?) part of my git config to use 1Password as the SSH agent.

[user]
	signingkey = ssh-ed25519 [redacted]

[gpg]
	format = ssh

[gpg "ssh"]
	program = "/Applications/1Password.app/Contents/MacOS/op-ssh-sign"

[commit]
	gpgsign = true

jsvensson avatar Feb 18 '24 00:02 jsvensson

Just adding my support for this! In additional to all the folks on Discord that have mentioned 1Password, I too would love to see support for their ssh-agent. More info at https://developer.1password.com/docs/ssh/agent for anyone that's looking.

Bonus points if you're able to support commit signing with SSH keys, but that should likely be raised as a separate issue.

bryanrossUK avatar Feb 20 '24 15:02 bryanrossUK

+1 for allowing ssh agents please

ShravanSunder avatar Feb 23 '24 14:02 ShravanSunder

Dunno if this is the same issue? But was trying to use gitbutler and it doesn't work for me because I use https://github.com/maxgoedjen/secretive for my SSH keys

danieltroger avatar Mar 04 '24 12:03 danieltroger

Would really appreciate this. Sadly blocking me from using GitButler.

trm217 avatar Mar 19 '24 21:03 trm217

We're experimenting with using the git binary for fetch and push, it feels likely it would unlock some of the above. #3222 #3227

mtsgrd avatar Mar 20 '24 01:03 mtsgrd

Can confirm that 1password now correctly prompts for approval when selecting the "Use a Git executable" option! 🚀

(Tested on v0.10.27)

Screenshot 2024-03-24 at 19 20 44

mackermans avatar Mar 24 '24 12:03 mackermans

+1 on that! This was the major blocker for me, preventing me from actually giving GitButler a fair shake. Looking forward to using it now!

jsvensson avatar Mar 24 '24 16:03 jsvensson

That was such a nice read, thanks for sharing!

Managed SSH keys seem to be working thanks to using the Git binary, so I am closing this issue as resolved. Please feel free to open new issues for other areas that might still need improvement, or reopen if this was the wrong call.

Byron avatar Apr 21 '24 20:04 Byron