lfs-test-server icon indicating copy to clipboard operation
lfs-test-server copied to clipboard

LFS_HOST insufficient when using HTTPS -> HTTP reverse proxy

Open elonen opened this issue 8 years ago • 0 comments

I have a use case, where I'm trying to use Apache reverse proxy to act as a HTTPS reverse proxy that redirect https://HOST/git-lfs/ to a backend lfs-test-server that's serving HTTP on locahost-only port 9999 (with non-root user that doesn't have access to SSL certificates).

The problem is, if I set LFS_HOST to https://HOST/git-lfs/, lfs-test-server builds malformed URLs like http://https://HOST/git-lfs/.

I propose checking if LFS_HOST starts with a protocol definition, and if so, omitting the http:// prefix it normally adds.

elonen avatar Sep 28 '17 11:09 elonen