git-credential-manager icon indicating copy to clipboard operation
git-credential-manager copied to clipboard

Published 20 hours ago • verified publisher icon git-ecosystem

Create new client ID for GCM when speaking to Azure Repos

Open mjcheetham opened this issue 6 years ago • 8 comments

We are currently using the same client ID as Visual Studio for ADAL (this is what GCM Windows also used). We should move to our own client ID, and have it join the Microsoft FoCI.

Question(s): should we join FoCI and become a 1st party app or not? Is consent not something we want to show?

mjcheetham avatar Jun 05 '19 09:06 mjcheetham

@mjcheetham this is only for Azure Repos, right? If so, I'll specify that in the title and we'll keep it open but marked "inactive" until we hear from the Repos team.

vtbassmatt avatar Feb 11 '21 15:02 vtbassmatt

Correct. Azure Repos only. Updated the title.

mjcheetham avatar Feb 11 '21 19:02 mjcheetham

Following :)

kyle-rader avatar Feb 11 '21 20:02 kyle-rader

In order to correctly support WAM (Windows broker) we require a new client ID/first-party application. Removing the inactive tag from this issue.

mjcheetham avatar Nov 30 '21 11:11 mjcheetham

ENT pos

Sidibe123 avatar May 03 '23 18:05 Sidibe123

How does this impact WAM? We use WAM today with the VS id without issue generally.

kyle-rader avatar May 03 '23 18:05 kyle-rader

We believe there is an issue using MSAs with the existing VS client ID as it was never enabled in the backend, and changing it after the fact is not possible. VS are moving to a new client ID also.

cc: @bgavrilMS

mjcheetham avatar May 15 '23 21:05 mjcheetham

@kyle-rader - VS uses a different client_id to talk to WAM. Most apps that use MSA-passthrough are not correctly configured to talk to WAM. Changing existing config is deemed too risky in some cases. New client id is better path forward.

bgavrilMS avatar May 23 '23 11:05 bgavrilMS